Conversation
AkarinServer
commented
Jan 23, 2026
- Bump Kiosk + Manager version to 1.0.0+7\n- Multi payment QR upload (Alipay/WeChat/custom)\n- Kiosk checkout: show all payment QRs, centered layout, success overlay\n- Pending payment restore: only restore if checkout was entered\n- Manager product price input: empty by default on add; 2-decimal validation/formatting\n\nPlease run required checks (lint-test) and merge.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47bc5c869b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| void _confirmPayment() { | ||
| if (_confirmed) return; | ||
| _confirmed = true; | ||
| unawaited(_settingsService.setPendingPaymentOrderId(null)); |
There was a problem hiding this comment.
Persist manual confirmations in order state
Manual confirmation via _confirmPayment() only clears the pending ID and triggers the UI callback, but it never marks the order as paid in the database. The Manager history view derives payment status from alipay_notify_checked_amount/wechat_notify_checked_amount (see Manager/lib/screens/kiosk_history_screen.dart), so any admin‑confirmed payments will show up as “pending” and can be misreported. If manual confirmation is expected when notification access isn’t available or for cash payments, this path should update the order record (or add a dedicated “manual paid” flag) so history and downstream logic don’t treat the order as unpaid.
Useful? React with 👍 / 👎.